Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4877

Fix analyzer factories to throw exception when arguments are invalid

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.3, 6.0
    • modules/analysis
    • None
    • New

    Description

      Currently if someone typos an argument "someParamater=xyz" instead of someParameter=xyz, they get no exception and sometimes incorrect behavior.

      It would be way better if these factories threw exception on unknown params, e.g. they removed the args they used and checked they were empty at the end.

      Attachments

        1. LUCENE-4877_one_solution_prototype.patch
          13 kB
          Robert Muir
        2. LUCENE-4877.patch
          569 kB
          Robert Muir
        3. LUCENE-4877.patch
          493 kB
          Robert Muir
        4. LUCENE-4877.patch
          246 kB
          Robert Muir
        5. LUCENE-4877-steve-minor-fixes.patch
          3 kB
          Steven Rowe
        6. LUCENE-4877-steve-more-param-parsing-verbs.patch
          68 kB
          Steven Rowe

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. SOLR-4813 Unavoidable IllegalArgumentException occurs when SynonymFilterFactory's setting has tokenizer factory's parameter.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            People

              Unassigned Unassigned
              rcmuir Robert Muir
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: