Lucene - Core
  1. Lucene - Core
  2. LUCENE-4863

Use FST to hold term in StemmerOverrideFilter

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: 4.3, master
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      follow-up from LUCENE-4857

      1. LUCENE-4863.patch
        22 kB
        Simon Willnauer
      2. LUCENE-4863.patch
        20 kB
        Simon Willnauer
      3. LUCENE-4863.patch
        20 kB
        Simon Willnauer

        Issue Links

          Activity

          Simon Willnauer created issue -
          Hide
          Simon Willnauer added a comment -

          here is a patch

          Show
          Simon Willnauer added a comment - here is a patch
          Simon Willnauer made changes -
          Field Original Value New Value
          Attachment LUCENE-4863.patch [ 12574577 ]
          Hide
          Simon Willnauer added a comment -

          slightly updated patch with some cleanups

          Show
          Simon Willnauer added a comment - slightly updated patch with some cleanups
          Simon Willnauer made changes -
          Attachment LUCENE-4863.patch [ 12574631 ]
          Simon Willnauer made changes -
          Link This issue is related to LUCENE-4857 [ LUCENE-4857 ]
          Hide
          Robert Muir added a comment -

          A few nits:

          • This converts to UTF-8, but stores in a BYTE4 automaton. Is there a reason for BYTE4
          • javadoc typeo "Adds an input string and it's stemmer overwrite output to this builder."
          • should the ignoreCase be a property of the map itself rather than a separate param? synoymfilter has this same problem. If you didnt previously add to the map properly (e.g. lowercase) then this parameter won't work.
          Show
          Robert Muir added a comment - A few nits: This converts to UTF-8, but stores in a BYTE4 automaton. Is there a reason for BYTE4 javadoc typeo "Adds an input string and it's stemmer overwrite output to this builder." should the ignoreCase be a property of the map itself rather than a separate param? synoymfilter has this same problem. If you didnt previously add to the map properly (e.g. lowercase) then this parameter won't work.
          Hide
          Robert Muir added a comment -

          oops, i see the utf-8 is for the output. this is good, nevermind the first comment

          Show
          Robert Muir added a comment - oops, i see the utf-8 is for the output. this is good, nevermind the first comment
          Hide
          Simon Willnauer added a comment -

          updated patch, fixing the typo and moving the ignoreCase into the map impl. I will commit this soon. Thanks for looking at it robert!

          Show
          Simon Willnauer added a comment - updated patch, fixing the typo and moving the ignoreCase into the map impl. I will commit this soon. Thanks for looking at it robert!
          Simon Willnauer made changes -
          Attachment LUCENE-4863.patch [ 12575294 ]
          Simon Willnauer made changes -
          Assignee Simon Willnauer [ simonw ]
          Hide
          Simon Willnauer added a comment -

          committed to 4.x (rev. 1460602) and trunk (rev. 1460580)

          Show
          Simon Willnauer added a comment - committed to 4.x (rev. 1460602) and trunk (rev. 1460580)
          Simon Willnauer made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          4d 17h 41m 1 Simon Willnauer 25/Mar/13 10:40
          Resolved Resolved Closed Closed
          45d 23h 54m 1 Uwe Schindler 10/May/13 10:34

            People

            • Assignee:
              Simon Willnauer
              Reporter:
              Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development