Lucene - Core
  1. Lucene - Core
  2. LUCENE-4846

PostingsHighlighter should allow [expert] customization on how the field values are loaded

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3, Trunk
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today it always loads from stored fields (searcher.doc), but it's sometimes
      useful to customize this, eg if your app separately already loads stored
      fields then it can avoid double-loading them. Or if your app has some other
      place to pull the values from ...

      1. LUCENE-4846.patch
        6 kB
        Michael McCandless
      2. LUCENE-4846.patch
        7 kB
        Michael McCandless

        Activity

        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458010

        LUCENE-4846: PostingsHighlighter allow customizing how the values to be highlighted are loaded (default is still stored fields)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458010 LUCENE-4846 : PostingsHighlighter allow customizing how the values to be highlighted are loaded (default is still stored fields)
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1458009

        LUCENE-4846: PostingsHighlighter allow customizing how the values to be highlighted are loaded (default is still stored fields)

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1458009 LUCENE-4846 : PostingsHighlighter allow customizing how the values to be highlighted are loaded (default is still stored fields)
        Hide
        Robert Muir added a comment -

        patch looks good!

        Show
        Robert Muir added a comment - patch looks good!
        Hide
        Michael McCandless added a comment -

        New patch, where the method allocates & returns the contents ...

        Show
        Michael McCandless added a comment - New patch, where the method allocates & returns the contents ...
        Hide
        Robert Muir added a comment -

        I agree with the general approach, but maybe it should create + return the array of values rather than have it passed by reference in?

        Show
        Robert Muir added a comment - I agree with the general approach, but maybe it should create + return the array of values rather than have it passed by reference in?
        Hide
        Michael McCandless added a comment -

        Simple patch: I added a protected method (loadFieldValues) to PH and a testcase.

        Show
        Michael McCandless added a comment - Simple patch: I added a protected method (loadFieldValues) to PH and a testcase.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development