Lucene - Core
  1. Lucene - Core
  2. LUCENE-4841

Add SortedSetDocValuesFacetField example to SimpleFacetsExample

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3, Trunk
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    1. LUCENE-4841.patch
      12 kB
      Michael McCandless
    2. LUCENE-4841.patch
      7 kB
      Michael McCandless

      Issue Links

        Activity

        Michael McCandless created issue -
        Michael McCandless made changes -
        Field Original Value New Value
        Link This issue is blocked by LUCENE-4840 [ LUCENE-4840 ]
        Hide
        Shai Erera added a comment -

        Actually I think this should belong in its own example class, because it does not allocate a taxoDir as well as cannot demo hierarchical facets. Perhaps that's what you meant to do anyway .

        Show
        Shai Erera added a comment - Actually I think this should belong in its own example class, because it does not allocate a taxoDir as well as cannot demo hierarchical facets. Perhaps that's what you meant to do anyway .
        Hide
        Michael McCandless added a comment -

        Patch, with new class just like SimpleFacetsExample ...

        Show
        Michael McCandless added a comment - Patch, with new class just like SimpleFacetsExample ...
        Michael McCandless made changes -
        Attachment LUCENE-4841.patch [ 12574067 ]
        Hide
        Shai Erera added a comment -

        Few comments:

        • Can you add a matching test case to demo/tests? See below, these tests are important to ensure the example code works!
        • Did you manage to run it without getting an exception? I.e. you add "Publish Date/2010/10/15", which SSDVFF should reject because it's hierarchical?
        • Also, main() points to SimpleFacetsExample().runSearch() and runDrillDown(). Hmm, maybe that's why you didn't trip on the hierarchy thing?

        TestSimpleFacetsExample is your friend .

        Show
        Shai Erera added a comment - Few comments: Can you add a matching test case to demo/tests? See below, these tests are important to ensure the example code works! Did you manage to run it without getting an exception? I.e. you add "Publish Date/2010/10/15", which SSDVFF should reject because it's hierarchical? Also, main() points to SimpleFacetsExample().runSearch() and runDrillDown(). Hmm, maybe that's why you didn't trip on the hierarchy thing? TestSimpleFacetsExample is your friend .
        Hide
        Michael McCandless added a comment -

        Woops, I will add a test

        Show
        Michael McCandless added a comment - Woops, I will add a test
        Hide
        Michael McCandless added a comment -

        New patch with test & CHANGES ... I think it's ready.

        Show
        Michael McCandless added a comment - New patch with test & CHANGES ... I think it's ready.
        Michael McCandless made changes -
        Attachment LUCENE-4841.patch [ 12574078 ]
        Hide
        Shai Erera added a comment -

        Looks good! +1

        Show
        Shai Erera added a comment - Looks good! +1
        Michael McCandless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1457546

        LUCENE-4841: add example for SortedSetDV facets

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1457546 LUCENE-4841 : add example for SortedSetDV facets
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1457545

        LUCENE-4841: add example for SortedSetDV facets

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1457545 LUCENE-4841 : add example for SortedSetDV facets
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        23h 41m 1 Michael McCandless 17/Mar/13 19:52
        Resolved Resolved Closed Closed
        53d 14h 41m 1 Uwe Schindler 10/May/13 11:34

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development