Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4836

SimpleRateLimiter#pause returns target time stamp instead of sleep time.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1, 4.2
    • Fix Version/s: 4.3, 4.2.1, 6.0
    • Component/s: core/store
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      SimpleRateLimiter#pause is supposed to return the time it actually spend sleeping but it returns the actual time in nanos it is supposed to sleep until. This cause some problems in ES due to long overflows.... here is the original issue reported by a user: https://github.com/elasticsearch/elasticsearch/issues/2785

      1. LUCENE-4836.patch
        4 kB
        Simon Willnauer

        Activity

        Hide
        simonw Simon Willnauer added a comment -

        here is a patch and a simple test

        Show
        simonw Simon Willnauer added a comment - here is a patch and a simple test
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [trunk commit] Simon Willnauer
        http://svn.apache.org/viewvc?view=revision&revision=1457154

        LUCENE-4836: Fix SimpleRateLimiter#pause to return the actual time spent sleeping

        Show
        commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Simon Willnauer http://svn.apache.org/viewvc?view=revision&revision=1457154 LUCENE-4836 : Fix SimpleRateLimiter#pause to return the actual time spent sleeping
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [branch_4x commit] Simon Willnauer
        http://svn.apache.org/viewvc?view=revision&revision=1457155

        LUCENE-4836: Fix SimpleRateLimiter#pause to return the actual time spent sleeping

        Show
        commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Simon Willnauer http://svn.apache.org/viewvc?view=revision&revision=1457155 LUCENE-4836 : Fix SimpleRateLimiter#pause to return the actual time spent sleeping
        Hide
        thetaphi Uwe Schindler added a comment -

        Closed after release.

        Show
        thetaphi Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            simonw Simon Willnauer
            Reporter:
            simonw Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development