Lucene - Core
  1. Lucene - Core
  2. LUCENE-4834

Sorter API: Make TermsEnum.docs accept any source of liveDocs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      TermsEnum.docs currently only works when liveDocs is null or the reader's liveDocs. This is enough for addIndexes but it would be cleaner to follow TermsEnum.docs contract and accept any source of liveDocs.

      1. LUCENE-4834.patch
        11 kB
        Adrien Grand

        Issue Links

          Activity

          Adrien Grand created issue -
          Hide
          Adrien Grand added a comment -

          Patch. I'll commit soon.

          Show
          Adrien Grand added a comment - Patch. I'll commit soon.
          Adrien Grand made changes -
          Field Original Value New Value
          Attachment LUCENE-4834.patch [ 12573849 ]
          Hide
          Shai Erera added a comment -

          Looks good! +1 to commit

          Show
          Shai Erera added a comment - Looks good! +1 to commit
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Adrien Grand
          http://svn.apache.org/viewvc?view=revision&revision=1456842

          LUCENE-4834: Sorter API: Make TermsEnum.docs accept any source of liveDocs.

          Show
          Commit Tag Bot added a comment - [trunk commit] Adrien Grand http://svn.apache.org/viewvc?view=revision&revision=1456842 LUCENE-4834 : Sorter API: Make TermsEnum.docs accept any source of liveDocs.
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Adrien Grand
          http://svn.apache.org/viewvc?view=revision&revision=1456851

          LUCENE-4834: Sorter API: Make TermsEnum.docs accept any source of liveDocs (merged from r1456842).

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Adrien Grand http://svn.apache.org/viewvc?view=revision&revision=1456851 LUCENE-4834 : Sorter API: Make TermsEnum.docs accept any source of liveDocs (merged from r1456842).
          Hide
          Adrien Grand added a comment -

          Thanks Shai.

          Show
          Adrien Grand added a comment - Thanks Shai.
          Adrien Grand made changes -
          Link This issue is related to LUCENE-3918 [ LUCENE-3918 ]
          Adrien Grand made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          1h 39m 1 Adrien Grand 15/Mar/13 10:16
          Resolved Resolved Closed Closed
          56d 17m 1 Uwe Schindler 10/May/13 10:34

            People

            • Assignee:
              Adrien Grand
              Reporter:
              Adrien Grand
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development