Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4834

Sorter API: Make TermsEnum.docs accept any source of liveDocs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      TermsEnum.docs currently only works when liveDocs is null or the reader's liveDocs. This is enough for addIndexes but it would be cleaner to follow TermsEnum.docs contract and accept any source of liveDocs.

      1. LUCENE-4834.patch
        11 kB
        Adrien Grand

        Issue Links

          Activity

          Hide
          jpountz Adrien Grand added a comment -

          Patch. I'll commit soon.

          Show
          jpountz Adrien Grand added a comment - Patch. I'll commit soon.
          Hide
          shaie Shai Erera added a comment -

          Looks good! +1 to commit

          Show
          shaie Shai Erera added a comment - Looks good! +1 to commit
          Hide
          commit-tag-bot Commit Tag Bot added a comment -

          [trunk commit] Adrien Grand
          http://svn.apache.org/viewvc?view=revision&revision=1456842

          LUCENE-4834: Sorter API: Make TermsEnum.docs accept any source of liveDocs.

          Show
          commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Adrien Grand http://svn.apache.org/viewvc?view=revision&revision=1456842 LUCENE-4834 : Sorter API: Make TermsEnum.docs accept any source of liveDocs.
          Hide
          commit-tag-bot Commit Tag Bot added a comment -

          [branch_4x commit] Adrien Grand
          http://svn.apache.org/viewvc?view=revision&revision=1456851

          LUCENE-4834: Sorter API: Make TermsEnum.docs accept any source of liveDocs (merged from r1456842).

          Show
          commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Adrien Grand http://svn.apache.org/viewvc?view=revision&revision=1456851 LUCENE-4834 : Sorter API: Make TermsEnum.docs accept any source of liveDocs (merged from r1456842).
          Hide
          jpountz Adrien Grand added a comment -

          Thanks Shai.

          Show
          jpountz Adrien Grand added a comment - Thanks Shai.
          Hide
          thetaphi Uwe Schindler added a comment -

          Closed after release.

          Show
          thetaphi Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              jpountz Adrien Grand
              Reporter:
              jpountz Adrien Grand
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development