Lucene - Core
  1. Lucene - Core
  2. LUCENE-4821

AnalyzingSuggester should use end() offset to decide if last token ended or not

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3, 6.0
    • Component/s: modules/spellchecker
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      For example, today if you index "i love lucy" and "isla de muerta", and then you ask for suggestions for "i" and for "i " (space after the i) you'll get the same results.

      But if we use the ending offset, we can determine (I think?) that there were non-token characters after the last token, so that "i " would only suggest "i love lucy".

      1. LUCENE-4821.patch
        8 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Patch.

        Show
        Michael McCandless added a comment - Patch.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1455339

        LUCENE-4821: AnalyzingSuggester uses end offset to determine whether the final token was finished or not

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1455339 LUCENE-4821 : AnalyzingSuggester uses end offset to determine whether the final token was finished or not
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1455338

        LUCENE-4821: AnalyzingSuggester uses end offset to determine whether the final token was finished or not

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1455338 LUCENE-4821 : AnalyzingSuggester uses end offset to determine whether the final token was finished or not
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development