Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, Trunk
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      there must be a better way!

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 20h 55m 1 Robert Muir 15/Feb/13 21:30
        Resolved Resolved Closed Closed
        83d 13h 2m 1 Uwe Schindler 10/May/13 11:32
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.
        Hide
        Commit Tag Bot added a comment -
        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446782 LUCENE-4779 : backport
        Robert Muir made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 5.0 [ 12321663 ]
        Resolution Fixed [ 1 ]
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446776

        LUCENE-4779: add remaining tests

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446776 LUCENE-4779 : add remaining tests
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446777

        LUCENE-4779: replace old TestSort

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446777 LUCENE-4779 : replace old TestSort
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446762

        LUCENE-4779: add missing values tests

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446762 LUCENE-4779 : add missing values tests
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446741

        LUCENE-4779: add custom parser tests

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446741 LUCENE-4779 : add custom parser tests
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446727

        LUCENE-4779: exercise all sorting collectors in this test

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446727 LUCENE-4779 : exercise all sorting collectors in this test
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446440

        LUCENE-4779: add docvalues and reverse tests

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446440 LUCENE-4779 : add docvalues and reverse tests
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446430

        LUCENE-4779: factor out collector tests

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446430 LUCENE-4779 : factor out collector tests
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446427

        LUCENE-4779: more simple tests

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446427 LUCENE-4779 : more simple tests
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446257

        LUCENE-4779: factor out testEmptyIndex

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446257 LUCENE-4779 : factor out testEmptyIndex
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446226

        LUCENE-4779: pull out more standalone tests

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446226 LUCENE-4779 : pull out more standalone tests
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446213

        LUCENE-4779: pull out test completely unrelated to sorting into its own test case

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446213 LUCENE-4779 : pull out test completely unrelated to sorting into its own test case
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446209

        LUCENE-4779: pull out a few good standalone tests from TestSort into TestSort2

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446209 LUCENE-4779 : pull out a few good standalone tests from TestSort into TestSort2
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1446202

        LUCENE-4779: add replacement for TestSort

        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1446202 LUCENE-4779 : add replacement for TestSort
        Hide
        Robert Muir added a comment -

        this test tries to be way too clever (tracers etc).

        it also tries to test way too many things: testing specialized collectors etc that belong in their own test.

        Instead i think a basic feature like Sort needs a ton of basic tests like TestDemo. I'd rather have hundreds of these little self-contained tests that are easy to debug.

        I plan to delete TestSort.java on friday: replacement or not. its wasting committers' time!

        Show
        Robert Muir added a comment - this test tries to be way too clever (tracers etc). it also tries to test way too many things: testing specialized collectors etc that belong in their own test. Instead i think a basic feature like Sort needs a ton of basic tests like TestDemo. I'd rather have hundreds of these little self-contained tests that are easy to debug. I plan to delete TestSort.java on friday: replacement or not. its wasting committers' time!
        Hide
        Dawid Weiss added a comment -

        There are three TestSort.java files (two in lucene, one in solr). I think it's confusing... but I guess I know which test from hell you're talking about

        Show
        Dawid Weiss added a comment - There are three TestSort.java files (two in lucene, one in solr). I think it's confusing... but I guess I know which test from hell you're talking about
        Robert Muir created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development