Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spinoff from LUCENE-3051. This method is not thread-safe unless you hold IndexWriter's lock.

      1. LUCENE-4775.patch
        9 kB
        Michael McCandless
      2. nuke.patch
        7 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        Lets also make SegmentInfo.sizeInBytes package-private.

        Show
        Robert Muir added a comment - Lets also make SegmentInfo.sizeInBytes package-private.
        Hide
        Simon Willnauer added a comment -

        Lets also make SegmentInfo.sizeInBytes package-private.

        +1

        Show
        Simon Willnauer added a comment - Lets also make SegmentInfo.sizeInBytes package-private. +1
        Hide
        Michael McCandless added a comment -

        +1, that looks great Rob!

        Show
        Michael McCandless added a comment - +1, that looks great Rob!
        Hide
        Michael McCandless added a comment -

        I started from Rob's patch, and then added simple fix for the thread safety, which is for IW to pre-compute the size in mergeInit and then the method just returns that.

        Show
        Michael McCandless added a comment - I started from Rob's patch, and then added simple fix for the thread safety, which is for IW to pre-compute the size in mergeInit and then the method just returns that.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1445978

        LUCENE-4775: nuke SegmentInfo.sizeInBytes; fix OneMerge.totalBytesSize thread safety

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1445978 LUCENE-4775 : nuke SegmentInfo.sizeInBytes; fix OneMerge.totalBytesSize thread safety
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1445981

        LUCENE-4775: nuke SegmentInfo.sizeInBytes; fix OneMerge.totalBytesSize thread safety

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1445981 LUCENE-4775 : nuke SegmentInfo.sizeInBytes; fix OneMerge.totalBytesSize thread safety
        Hide
        Robert Muir added a comment -

        The test added here doesn't even use its indexwriterconfig.

        Show
        Robert Muir added a comment - The test added here doesn't even use its indexwriterconfig.
        Hide
        Commit Tag Bot added a comment -
        Show
        Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1447034 LUCENE-4775 : speed up test
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1447035

        LUCENE-4775: speed up test

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1447035 LUCENE-4775 : speed up test
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1448628

        LUCENE-4775: move computation of merge bytes size earlier

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1448628 LUCENE-4775 : move computation of merge bytes size earlier
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1448629

        LUCENE-4775: move computation of merge bytes size earlier

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1448629 LUCENE-4775 : move computation of merge bytes size earlier
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development