Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, 6.0
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Facets packages have a weird structure IMO. I think that we should organize the packages by feature, and not by functionality (index/search). For example:

      • o.a.l.facet.index – core facets indexing
      • o.a.l.facet.search – core facets search
      • o.a.l.facet.params – all facets params (indexing and search)
      • o.a.l.facet.associations – all associations code (we can break to sub-index/search packages if needed)
      • o.a.l.facet.partitions – all partitions related code
      • o.a.l.facet.sampling – all sampling related code
      • o.a.l.facet.util – consolidate all utils under that, even those that are currently under o.a.l.util
      • o.a.l.facet.encoding – move all encoders under it (from o.a.l.util)
      • o.a.l.facet.taxonomy – all taxonomy related stuff.

      The motivation – if I want to handle all associations related code, it should be very easy to locate it.

        Activity

        Hide
        Shai Erera added a comment -

        I'm done with this. Not going to post an issue since it's just moves and import fixes. I did add one class PerCategoryListAggregator (which invokes the right aggregator per CLP when asked).

        Show
        Shai Erera added a comment - I'm done with this. Not going to post an issue since it's just moves and import fixes. I did add one class PerCategoryListAggregator (which invokes the right aggregator per CLP when asked).
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1444043

        LUCENE-4761: Facets package reorganization

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1444043 LUCENE-4761 : Facets package reorganization
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1444026

        LUCENE-4761: Facets package reorganization

        Show
        Commit Tag Bot added a comment - [trunk commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1444026 LUCENE-4761 : Facets package reorganization
        Hide
        Shai Erera added a comment -

        Committed to trunk and 4x

        Show
        Shai Erera added a comment - Committed to trunk and 4x
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development