+1 for Java 7.

I would open some issues to update syntax sugar and fix some reflection-based hacks (e.g. IOUtils.addSuppressed). We also need to update Constants.java and so on, reconfigure Policeman Jenkins JDK randomization for trunk jobs,...

+1

+1

+1

+1

An incomplete patch. just did a lot of the boilerplate stuff (and lots of searches thru the codebase for "java6", "java 6", "1.6") etc

We have the first issue with FSDirectpry implementations that makes the move to Java 7 needed: LUCENE-4848

I took this issue and will setup the basic Java 7 support with Robert's patch.

Updated patch (the build fails now when java 6 is used before even compiling). This is now possible by the new Java detection added in Lucene trunk/4.x after this issue was opened and the initial patch was submitted:

BUILD FAILED
C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr3\build.xml:249: The following error occurred while executing this line:
C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr3\lucene\build.xml:23: The following error occurred while executing this line:
C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr3\lucene\common-build.xml:285: Minimum supported Java version is 1.7.

Total time: 0 seconds

I changed all Jenkins instances I had access to. Currently Simonw should disable the flonkins Java 6 Job for Lucene trunk.

I will commit the patch soon!

[trunk commit] Uwe Schindler
http://svn.apache.org/viewvc?view=revision&revision=1457734

LUCENE-4747: Move to Java 7 in trunk

[trunk commit] Uwe Schindler
http://svn.apache.org/viewvc?view=revision&revision=1457747

LUCENE-4747: Fix nocommits

[trunk commit] Uwe Schindler
http://svn.apache.org/viewvc?view=revision&revision=1457751

LUCENE-4747: Remove reflection from IOUtils for supressing caughth Exceptions

The move is done.

Before resolving the issue I wanted the confirmation by Steven Rowe, if the Maven build is setup correctly (e.g. maven-enforcer-plugin,...).

I have to also investigate the "clover" build. The version of Clover we currently use is not compatible with Java 7, so we might need to upgrade.

Maybe we should fix all places that should use Integer.compare/Long.compare/... too?

+1, go ahead!

Before resolving the issue I wanted the confirmation by Steven Rowe, if the Maven build is setup correctly (e.g. maven-enforcer-plugin,...).

Enforcer seems to work fine. forbiddenapis, compilation and enforcer all use the ${java.compat.version} property that you changed to 1.7, so I think the Maven build is all set.

When I attempt mvn install with Java6, I see this:

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireJavaVersion failed with message:
Java 1.7+ is required.

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.053s
[INFO] Finished at: Mon Mar 18 10:21:11 EDT 2013
[INFO] Final Memory: 17M/81M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.2:enforce (enforce-java-compat-version-and-maven-2.2.1) on project lucene-solr-grandparent: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Thanks!
I'll close this issue now and we should open followup issues for the remaining tasks.