Lucene - Core
  1. Lucene - Core
  2. LUCENE-4686

Write a specialized DGapVIntEncoder/Decoder for facets

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, Trunk
    • Component/s: modules/facet
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Today the default encoder/decoder for facets is DGap(VInt). That is a DGapEncoder wrapping a VIntEncoder. Instead of this wrapping, we can write a specialized DGapVIntEncoder which does it all in one call.

        Activity

        Shai Erera created issue -
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Shai Erera added a comment -

        Adds DGapVInt8IntEncoder/Decoder. At least according to EncodingSpeed, it's faster than DGap(VInt8), but we should test w/ luceneutil.

        I set it as the default encoder/decoder in CLP, with a nocommit until luceneutil blesses it.

        Show
        Shai Erera added a comment - Adds DGapVInt8IntEncoder/Decoder. At least according to EncodingSpeed, it's faster than DGap(VInt8), but we should test w/ luceneutil. I set it as the default encoder/decoder in CLP, with a nocommit until luceneutil blesses it.
        Shai Erera made changes -
        Field Original Value New Value
        Attachment LUCENE-4686.patch [ 12565123 ]
        Hide
        Michael McCandless added a comment -

        +1

                            Task    QPS base      StdDev    QPS comp      StdDev                Pct diff
                        PKLookup      181.92      (1.3%)      181.25      (2.0%)   -0.4% (  -3% -    2%)
                         LowTerm       83.54      (2.0%)       85.61      (2.6%)    2.5% (  -2% -    7%)
                         MedTerm       31.53      (0.9%)       33.01      (1.7%)    4.7% (   2% -    7%)
                        HighTerm       19.41      (0.8%)       20.57      (1.6%)    6.0% (   3% -    8%)
        
        Show
        Michael McCandless added a comment - +1 Task QPS base StdDev QPS comp StdDev Pct diff PKLookup 181.92 (1.3%) 181.25 (2.0%) -0.4% ( -3% - 2%) LowTerm 83.54 (2.0%) 85.61 (2.6%) 2.5% ( -2% - 7%) MedTerm 31.53 (0.9%) 33.01 (1.7%) 4.7% ( 2% - 7%) HighTerm 19.41 (0.8%) 20.57 (1.6%) 6.0% ( 3% - 8%)
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1433935

        LUCENE-4686: Write a specialized DGapVIntEncoder/Decoder for facets

        Show
        Commit Tag Bot added a comment - [trunk commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1433935 LUCENE-4686 : Write a specialized DGapVIntEncoder/Decoder for facets
        Hide
        Shai Erera added a comment -

        Thanks Mike. Committed to trunk and 4x.

        Show
        Shai Erera added a comment - Thanks Mike. Committed to trunk and 4x.
        Shai Erera made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 5.0 [ 12321663 ]
        Resolution Fixed [ 1 ]
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1433938

        LUCENE-4686: Write a specialized DGapVIntEncoder/Decoder for facets

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1433938 LUCENE-4686 : Write a specialized DGapVIntEncoder/Decoder for facets
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        18h 56m 1 Shai Erera 16/Jan/13 14:00
        Resolved Resolved Closed Closed
        113d 20h 33m 1 Uwe Schindler 10/May/13 11:33

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development