Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1
    • Component/s: modules/spellchecker
    • Labels:
      None
    • Environment:

      Currently the suggestSimilar() that actually operates on the FuzzyTermy is private protected. Would be great if that would just be protected for extensions.

    • Lucene Fields:
      New
    1. LUCENE-4684.patch
      4 kB
      Martijn van Groningen

      Activity

      Hide
      Martijn van Groningen added a comment -

      Made all the fields of DirectSpellChecker protected, the suggestSimilar method and the ScoreTerm inner class.

      Show
      Martijn van Groningen added a comment - Made all the fields of DirectSpellChecker protected, the suggestSimilar method and the ScoreTerm inner class.
      Hide
      Martijn van Groningen added a comment -

      Committed to trunk, branch4x and lucene_solr_4_1 branches

      Show
      Martijn van Groningen added a comment - Committed to trunk, branch4x and lucene_solr_4_1 branches
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433443

      LUCENE-4684: Moved change entry log.

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433443 LUCENE-4684 : Moved change entry log.
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433438

      LUCENE-4684: Made DirectSpellChecker extendable.

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433438 LUCENE-4684 : Made DirectSpellChecker extendable.
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433444

      LUCENE-4684: Moved change entry log.

      Show
      Commit Tag Bot added a comment - [trunk commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433444 LUCENE-4684 : Moved change entry log.
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433431

      LUCENE-4684: Made DirectSpellChecker extendable.

      Show
      Commit Tag Bot added a comment - [trunk commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433431 LUCENE-4684 : Made DirectSpellChecker extendable.
      Hide
      Robert Muir added a comment -

      Can we add javadocs to all the new protected stuff?

      I don't know why Jenkins isn't failing, but it should be.

      Also can we not make the instance vars protected

      Show
      Robert Muir added a comment - Can we add javadocs to all the new protected stuff? I don't know why Jenkins isn't failing, but it should be. Also can we not make the instance vars protected
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433932

      LUCENE-4684: Added jdoc and made fields private again.

      Show
      Commit Tag Bot added a comment - [trunk commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433932 LUCENE-4684 : Added jdoc and made fields private again.
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433934

      LUCENE-4684: Added jdoc and made fields private again.

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433934 LUCENE-4684 : Added jdoc and made fields private again.
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433933

      LUCENE-4684: Made fields private again (2).

      Show
      Commit Tag Bot added a comment - [trunk commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433933 LUCENE-4684 : Made fields private again (2).
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433992

      LUCENE-4684: Fixed jdocs attempt 2

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433992 LUCENE-4684 : Fixed jdocs attempt 2
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Martijn van Groningen
      http://svn.apache.org/viewvc?view=revision&revision=1433993

      LUCENE-4684: Made fields private again (2).

      Show
      Commit Tag Bot added a comment - [trunk commit] Martijn van Groningen http://svn.apache.org/viewvc?view=revision&revision=1433993 LUCENE-4684 : Made fields private again (2).

        People

        • Assignee:
          Martijn van Groningen
          Reporter:
          Martijn van Groningen
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development