Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-BETA
    • Fix Version/s: 4.1
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      It seems org.apache.lucene.analysis.fr.FrenchAnalyzer.DEFAULT_ARTICLES is missing "d" and "c", but also "jusqu", "quoiqu", "lorsqu", and "puisqu".

        Activity

        Hide
        Steve Rowe added a comment -

        Trivial patch adding these articles.

        Committing shortly.

        Show
        Steve Rowe added a comment - Trivial patch adding these articles. Committing shortly.
        Hide
        Steve Rowe added a comment -
        Show
        Steve Rowe added a comment - David, I went looking for a complete list, and found http://books.google.com/books?id=JocEfO__dvYC&pg=PA29&lpg=PA29&dq=%22jusqu%22,+%22quoiqu%22,+%22lorsqu%22,+and+%22puisqu%22.&source=bl&ots=Cetw__ZoiM&sig=Ux3_rSFEw3bhznCiaPg1g0YFi80&hl=en&sa=X&ei=HHHnUOitIIiy0QGQvYCgAQ&ved=0CEwQ6AEwAw#v=onepage&q=jusqu%20quoiqu%20lorsqu%20puisqu&f=false and http://monsu.desiderio.free.fr/curiosites/elision.html . Looks to me like the only two additional ones mentioned ("quelqu" in "quelqu'un" and "presqu" in "presqu'île") are compound words that shouldn't be broken up.
        Hide
        Steve Rowe added a comment -

        Committed to trunk and branch_4x.

        Thanks David!

        Show
        Steve Rowe added a comment - Committed to trunk and branch_4x. Thanks David!
        Hide
        David L added a comment - - edited

        Yes, that's why I did not add those.

        And according to one of the most renown French grammar guide (Grevisse/Bon usage) "quelque" and "presque" are never elided in other circumstances than "quelqu'un" and "presqu'île".
        http://www.lebonusage.com/public/5CFD7A92-727A0D5B-65A0-66C60D99-A68F5305BA79 (temporary URL)

        Thanks !

        Show
        David L added a comment - - edited Yes, that's why I did not add those. And according to one of the most renown French grammar guide (Grevisse/Bon usage) "quelque" and "presque" are never elided in other circumstances than "quelqu'un" and "presqu'île". http://www.lebonusage.com/public/5CFD7A92-727A0D5B-65A0-66C60D99-A68F5305BA79 (temporary URL) Thanks !
        Hide
        Robert Muir added a comment -

        can we also add these to: /solr/example/solr/collection1/conf/lang$ more contractions_fr.txt

        1. Set of French contractions for ElisionFilter
        2. TODO: load this as a resource from the analyzer and sync it in build.xml
          l
          m
          t
          qu
          n
          s
          j

        If no one beats me to it, ill take care of it... its currently not automagic in any way though,
        but would be nice to stay in sync!

        Show
        Robert Muir added a comment - can we also add these to: /solr/example/solr/collection1/conf/lang$ more contractions_fr.txt Set of French contractions for ElisionFilter TODO: load this as a resource from the analyzer and sync it in build.xml l m t qu n s j If no one beats me to it, ill take care of it... its currently not automagic in any way though, but would be nice to stay in sync!
        Hide
        Steve Rowe added a comment -

        Thanks Robert, I'll add them in the Solr example too.

        Show
        Steve Rowe added a comment - Thanks Robert, I'll add them in the Solr example too.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1429193

        LUCENE-4662: Add missing elided articles and prepositions to French ElisionFilter list under Solr example

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1429193 LUCENE-4662 : Add missing elided articles and prepositions to French ElisionFilter list under Solr example
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1429178

        LUCENE-4662: CHANGES.txt entry

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1429178 LUCENE-4662 : CHANGES.txt entry
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1429175

        LUCENE-4662: Add missing elided articles and prepositions to FrenchAnalyzer's list passed to ElisionFilter

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1429175 LUCENE-4662 : Add missing elided articles and prepositions to FrenchAnalyzer's list passed to ElisionFilter
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1429191

        LUCENE-4662: Add missing elided articles and prepositions to French ElisionFilter list under Solr example

        Show
        Commit Tag Bot added a comment - [trunk commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1429191 LUCENE-4662 : Add missing elided articles and prepositions to French ElisionFilter list under Solr example
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1429177

        LUCENE-4662: CHANGES.txt entry

        Show
        Commit Tag Bot added a comment - [trunk commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1429177 LUCENE-4662 : CHANGES.txt entry
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Steven Rowe
        http://svn.apache.org/viewvc?view=revision&revision=1429174

        LUCENE-4662: Add missing elided articles and prepos to FrenchAnalyzer's list passed to ElisionFilter

        Show
        Commit Tag Bot added a comment - [trunk commit] Steven Rowe http://svn.apache.org/viewvc?view=revision&revision=1429174 LUCENE-4662 : Add missing elided articles and prepos to FrenchAnalyzer's list passed to ElisionFilter

          People

          • Assignee:
            Steve Rowe
            Reporter:
            David L
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development