Lucene - Core
  1. Lucene - Core
  2. LUCENE-4660

When ConcurrentMergeScheduler stalls incoming threads it has unexpected hysteresis

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Eg if you set maxMergeCount to 2, as soon as a 3rd merge need to kick off, we stall incoming segment-creating threads. Then we wait ... and we are supposed to resume the threads when the merge count drops back to 2, but instead we are only resuming when merge count gets to 1. Ie, we stall for too long (= unexpected hysteresis).

      1. LUCENE-4660.patch
        0.9 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Simple patch: we were missing a notifyAll after a single merge thread pulls its next merge.

        Show
        Michael McCandless added a comment - Simple patch: we were missing a notifyAll after a single merge thread pulls its next merge.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1428951

        LUCENE-4660: add missing notifyAll after merge finishes

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1428951 LUCENE-4660 : add missing notifyAll after merge finishes
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Michael McCandless
        http://svn.apache.org/viewvc?view=revision&revision=1428949

        LUCENE-4660: add missing notifyAll after merge finishes

        Show
        Commit Tag Bot added a comment - [trunk commit] Michael McCandless http://svn.apache.org/viewvc?view=revision&revision=1428949 LUCENE-4660 : add missing notifyAll after merge finishes

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development