Lucene - Core
  1. Lucene - Core
  2. LUCENE-4642

Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

    Details

    • Lucene Fields:
      New, Patch Available

      Description

      All tokenizer implementations have a constructor that takes a given AttributeSource as parameter (LUCENE-1826). These should be removed.

      TokenizerFactory does not provide an API to create tokenizers with a given AttributeFactory, but quite a few tokenizers have constructors that take an AttributeFactory. TokenizerFactory should add a create(AttributeFactory) method, as should subclasses for tokenizers with AttributeFactory accepting ctors.

      1. TrieTokenizerFactory.java.patch
        2 kB
        Uwe Schindler
      2. LUCENE-4642-single-create-method-on-TokenizerFactory-subclasses.patch
        33 kB
        Steve Rowe
      3. LUCENE-4642-single-create-method-on-TokenizerFactory-subclasses.patch
        32 kB
        Steve Rowe
      4. LUCENE-4642.patch
        25 kB
        Renaud Delbru
      5. LUCENE-4642.patch
        18 kB
        Steve Rowe
      6. LUCENE-4642.patch
        34 kB
        Renaud Delbru
      7. LUCENE-4642.patch
        35 kB
        Steve Rowe

        Activity

        Renaud Delbru created issue -
        Renaud Delbru made changes -
        Field Original Value New Value
        Attachment LUCENE-4642.patch [ 12561902 ]
        Mark Miller made changes -
        Fix Version/s 5.0 [ 12321663 ]
        Mark Miller made changes -
        Fix Version/s 4.2 [ 12323899 ]
        Fix Version/s 4.1 [ 12321140 ]
        Steve Rowe made changes -
        Assignee Steve Rowe [ steve_rowe ]
        Steve Rowe made changes -
        Attachment LUCENE-4642.patch [ 12565782 ]
        Uwe Schindler made changes -
        Attachment TrieTokenizerFactory.java.patch [ 12566666 ]
        Renaud Delbru made changes -
        Attachment LUCENE-4642.patch [ 12567784 ]
        Robert Muir made changes -
        Fix Version/s 4.3 [ 12324143 ]
        Fix Version/s 5.0 [ 12321663 ]
        Fix Version/s 4.2 [ 12323899 ]
        Steve Rowe made changes -
        Summary TokenizerFactory should provide a create method with a given AttributeSource Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource
        Steve Rowe made changes -
        Description All tokenizer implementations have a constructor that takes a given AttributeSource as parameter (LUCENE-1826). However, the TokenizerFactory does not provide an API to create tokenizers with a given AttributeSource.

        Side note: There are still a lot of tokenizers that do not provide constructors that take AttributeSource and AttributeFactory.
        All tokenizer implementations have a constructor that takes a given AttributeSource as parameter (LUCENE-1826). These should be removed.

        TokenizerFactory does not provide an API to create tokenizers with a given AttributeFactory, but quite a few tokenizers have constructors that take an AttributeFactory. TokenizerFactory should add a create(AttributeFactory) method, as should subclasses for tokenizers with AttributeFactory accepting ctors.
        Steve Rowe made changes -
        Attachment LUCENE-4642.patch [ 12573369 ]
        Steve Rowe made changes -
        Steve Rowe made changes -
        Steve Rowe made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 5.0 [ 12321663 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Renaud Delbru
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development