Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4642

Add create(AttributeFactory) to TokenizerFactory and subclasses with ctors taking AttributeFactory, and remove Tokenizer's and subclasses' ctors taking AttributeSource

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • New, Patch Available

    Description

      All tokenizer implementations have a constructor that takes a given AttributeSource as parameter (LUCENE-1826). These should be removed.

      TokenizerFactory does not provide an API to create tokenizers with a given AttributeFactory, but quite a few tokenizers have constructors that take an AttributeFactory. TokenizerFactory should add a create(AttributeFactory) method, as should subclasses for tokenizers with AttributeFactory accepting ctors.

      Attachments

        1. LUCENE-4642.patch
          35 kB
          Steven Rowe
        2. LUCENE-4642.patch
          34 kB
          Renaud Delbru
        3. LUCENE-4642.patch
          18 kB
          Steven Rowe
        4. LUCENE-4642.patch
          25 kB
          Renaud Delbru
        5. LUCENE-4642-single-create-method-on-TokenizerFactory-subclasses.patch
          32 kB
          Steven Rowe
        6. LUCENE-4642-single-create-method-on-TokenizerFactory-subclasses.patch
          33 kB
          Steven Rowe
        7. TrieTokenizerFactory.java.patch
          2 kB
          Uwe Schindler

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sarowe Steven Rowe
            renaud.delbru Renaud Delbru
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment