[LUCENE-4633] DirectoryTaxonomyWriter.replaceTaxonomy should refresh the reader

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.1, 6.0
• Component/s: modules/facet
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Shai Erera
• Created: 16/Dec/12 09:49
• Updated: 28/Aug/22 13:34
• Resolved: 16/Dec/12 10:17

Description

While migrating code to Lucene 4.0 I tripped it. If you call replaceTaxonomy() with e.g. a taxonomy index that contains category "a", and then you try to add category "a" to the new taxonomy, it receives a new ordinal!

The reason is that replaceTaxo doesn't refresh the internal IndexReader, but does clear the cache (as it should). This causes the next addCategory to not find category "a" in the cache, and not in the reader instance at hand.

Simple fix, I'll attach a patch with it and a test exposing the bug.