Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4625

Make TotalFacetCounts per-segment

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • modules/facet
    • None
    • New

    Description

      TotalFacetCounts are used during complements computation today. They are not per-segment and therefore are not NRT friendly. Even regardless to NRT, you need to compute them entirely from scratch whenever you reopen IR.

      It would be good if we can develop them per-segment. If e.g. AtomicReader had a notion of cachable objects, it could be such an object. That has been discussed many times in the past though, without a consensus. So perhaps we can have a FacetsAtomicReader which manages TFC. But that creates other issues too, like who instantiates that AtomicReader (i.e. we'd need a FacetsCompositeReader too, and potentially IW would need to init that type) ...

      Let's explore these options, but in general it would be good to have TFC per-segment.

      Attachments

        Activity

          People

            Unassigned Unassigned
            shaie Shai Erera
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: