Lucene - Core
  1. Lucene - Core
  2. LUCENE-4605

Add FLAG_NONE to DocsEnum and DocsAndPositionsEnum

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1, 6.0
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Add a convenience constants FLAGS_NONE to DocsEnum and DocsAndPositionsEnum. Today, if someone e.g. wants to get the docs only, he needs to pass 0 as the flags, but the value of 0 is not documented anywhere. I had to dig in the code the verify that indeed that's the value.

      I'll attach a patch later.

        Activity

        Hide
        Shai Erera added a comment -

        Patch adds DocsEnum.FLAG_NONE with proper javadocs. I also modified all places in the code that I could find which passed 0, to pass the new constant.

        Basically a trivial change. 'core' tests passed. If there are no objections, I will commit it later today.

        Show
        Shai Erera added a comment - Patch adds DocsEnum.FLAG_NONE with proper javadocs. I also modified all places in the code that I could find which passed 0, to pass the new constant. Basically a trivial change. 'core' tests passed. If there are no objections, I will commit it later today.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1419991

        LUCENE-4605: Add FLAG_NONE to DocsEnum and DocsAndPositionsEnum

        Show
        Commit Tag Bot added a comment - [trunk commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1419991 LUCENE-4605 : Add FLAG_NONE to DocsEnum and DocsAndPositionsEnum
        Hide
        Shai Erera added a comment -

        Committed to trunk and 4x.

        Show
        Shai Erera added a comment - Committed to trunk and 4x.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Shai Erera
        http://svn.apache.org/viewvc?view=revision&revision=1419994

        LUCENE-4605: Add FLAG_NONE to DocsEnum and DocsAndPositionsEnum

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Shai Erera http://svn.apache.org/viewvc?view=revision&revision=1419994 LUCENE-4605 : Add FLAG_NONE to DocsEnum and DocsAndPositionsEnum

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development