Lucene - Core
  1. Lucene - Core
  2. LUCENE-4588

EnwikiContentSource silently swallows the last wiki doc

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: modules/benchmark
    • Labels:
      None

      Description

      Last wiki doc is never returned

        Activity

        Hide
        Doron Cohen added a comment -

        In addition, there's a thread leak in 'forever' mode.

        Show
        Doron Cohen added a comment - In addition, there's a thread leak in 'forever' mode.
        Hide
        Doron Cohen added a comment -

        Patch adds a test for enwiki-content-source and fixes both the last doc problem and the thread leak.

        Show
        Doron Cohen added a comment - Patch adds a test for enwiki-content-source and fixes both the last doc problem and the thread leak.
        Hide
        Shai Erera added a comment -

        Patch looks good ! Nice catch. Few minor (styling) comments, feel free to ignore:

        • In EnwikiCSTest.Stringable, I would make docs 'final'.
        • I would change assertNoMoreDataException like this:
        private void assertNoMoreDataException(EnwikiContentSource stdm) throws Exception {
          try {
            stdm.getNextDocData(null);
            fail("Expecting NoMoreDataException");
          } catch (NoMoreDataException e) {
            // expected
          }
        }
        
        Show
        Shai Erera added a comment - Patch looks good ! Nice catch. Few minor (styling) comments, feel free to ignore: In EnwikiCSTest.Stringable, I would make docs 'final'. I would change assertNoMoreDataException like this: private void assertNoMoreDataException(EnwikiContentSource stdm) throws Exception { try { stdm.getNextDocData( null ); fail( "Expecting NoMoreDataException" ); } catch (NoMoreDataException e) { // expected } }
        Hide
        Doron Cohen added a comment -

        Thanks for the review Shai, changed as you suggested and committed (while jira was down...)

        Show
        Doron Cohen added a comment - Thanks for the review Shai, changed as you suggested and committed (while jira was down...)
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Doron Cohen
        http://svn.apache.org/viewvc?view=revision&revision=1417788

        LUCENE-4588: EnwikiContentSource fixes: lost last wiki doc, thread leak in 'forever' mode.

        Show
        Commit Tag Bot added a comment - [trunk commit] Doron Cohen http://svn.apache.org/viewvc?view=revision&revision=1417788 LUCENE-4588 : EnwikiContentSource fixes: lost last wiki doc, thread leak in 'forever' mode.
        Hide
        Doron Cohen added a comment -

        Two more commits to trunk (uncaught by bot due to incorrect message format):

        Show
        Doron Cohen added a comment - Two more commits to trunk (uncaught by bot due to incorrect message format): r1417871 – LUCENE-4588 (cont): (EnwikiContentSource fixes) avoid using the forbidden StringBufferInputStream.. r1417921 – LUCENE-4588 (cont): simplify test input stream crration.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Doron Cohen
        http://svn.apache.org/viewvc?view=revision&revision=1418892

        LUCENE-4588: merge from trunk: EnwikiContentSource silently swallows the last wiki doc.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Doron Cohen http://svn.apache.org/viewvc?view=revision&revision=1418892 LUCENE-4588 : merge from trunk: EnwikiContentSource silently swallows the last wiki doc.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Doron Cohen
        http://svn.apache.org/viewvc?view=revision&revision=1418894

        LUCENE-4588: (cont) add missing property svn:eol-style.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Doron Cohen http://svn.apache.org/viewvc?view=revision&revision=1418894 LUCENE-4588 : (cont) add missing property svn:eol-style.
        Hide
        Doron Cohen added a comment -

        Fixed.

        As a side note, merging benchmark changes to 4x is so much easier than it used to be in 3x, now that trunk and branch are structured the same! Now if only 'precommit' would run 60 times faster (that would be 12 seconds here)... wouldn't that be great?

        Show
        Doron Cohen added a comment - Fixed. As a side note, merging benchmark changes to 4x is so much easier than it used to be in 3x, now that trunk and branch are structured the same! Now if only 'precommit' would run 60 times faster (that would be 12 seconds here)... wouldn't that be great?
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Doron Cohen
        http://svn.apache.org/viewvc?view=revision&revision=1418894

        LUCENE-4588: (cont) add missing property svn:eol-style.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Doron Cohen http://svn.apache.org/viewvc?view=revision&revision=1418894 LUCENE-4588 : (cont) add missing property svn:eol-style.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Doron Cohen
        http://svn.apache.org/viewvc?view=revision&revision=1418892

        LUCENE-4588: merge from trunk: EnwikiContentSource silently swallows the last wiki doc.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Doron Cohen http://svn.apache.org/viewvc?view=revision&revision=1418892 LUCENE-4588 : merge from trunk: EnwikiContentSource silently swallows the last wiki doc.

          People

          • Assignee:
            Doron Cohen
            Reporter:
            Doron Cohen
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development