Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We removed this before because of LUCENE-2828,
      but the problem there was the delegator (not the lengthNorm method).

      TFIDFSim requires byte[] norms today. So its computeNorm should be final,
      calling lengthNorm() that returns a byte.

      This way there is no possibility for you to do something stupid.

        Activity

        Hide
        Robert Muir added a comment -

        Here's the patch.

        The api bug was introduced when sim was expanded to use norms beside a single byte: at query-time TFIDFSim is limited to single-byte norms (the code bits are final), but computeNorm is not final.

        I'll commit soon.

        Show
        Robert Muir added a comment - Here's the patch. The api bug was introduced when sim was expanded to use norms beside a single byte: at query-time TFIDFSim is limited to single-byte norms (the code bits are final), but computeNorm is not final. I'll commit soon.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Simon Willnauer added a comment -

        +1 thanks robert!

        Show
        Simon Willnauer added a comment - +1 thanks robert!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1406422

        LUCENE-4543: bring back TFIDFSimilarity.lengthNorm

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1406422 LUCENE-4543 : bring back TFIDFSimilarity.lengthNorm

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development