Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4504

Empty results from IndexSearcher.searchAfter() when sorting by FunctionValues

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: 4.0
        • Fix Version/s: 4.3, 6.0
        • Component/s: modules/other
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          IS.searchAfter() always returns an empty result when using FunctionValues for sorting.

          The culprit is ValueSourceComparator.compareDocToValue() returning -1 when it should return +1.

          1. Text File
            LUCENE-4504.patch
            5 kB
            Robert Muir
          2. Text File
            LUCENE-4504.patch
            0.5 kB
            TomShally
          3. Java Source File
            Lucene4504Test.java
            3 kB
            TomShally

            Issue Links

            is related to

            Improvement - An improvement or enhancement to an existing feature or task. LUCENE-3514 deep paging with Sort

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              tomsh TomShally added a comment -

              Patch against trunk

              Show
              tomsh TomShally added a comment - Patch against trunk
              Hide
              Permalink
              mikemccand Michael McCandless added a comment -

              That's definitely a bug, and the fix looks good (though are we sure the first if shouldn't return 1?).

              Do you have a test showing the bug/fix? Thanks.

              Show
              mikemccand Michael McCandless added a comment - That's definitely a bug, and the fix looks good (though are we sure the first if shouldn't return 1?). Do you have a test showing the bug/fix? Thanks.
              Hide
              Permalink
              tomsh TomShally added a comment -

              Attached test fails with trunk, passes with patch.

              are we sure the first if shouldn't return 1?

              According to the javadocs and test: yes. It's supposed to compare the candidate (doc, docValue) against the "after" value (valueObj, value) and return -1 if the candidate is less than the provided after value.

              Show
              tomsh TomShally added a comment - Attached test fails with trunk, passes with patch. are we sure the first if shouldn't return 1? According to the javadocs and test: yes. It's supposed to compare the candidate (doc, docValue) against the "after" value (valueObj, value) and return -1 if the candidate is less than the provided after value.
              Hide
              Permalink
              rcmuir Robert Muir added a comment -

              Thanks for the test Tom!

              I rolled both these into a combined patch: I'll commit soon.

              Show
              rcmuir Robert Muir added a comment - Thanks for the test Tom! I rolled both these into a combined patch: I'll commit soon.
              Hide
              Permalink
              rcmuir Robert Muir added a comment -

              Thanks again Tom!

              Show
              rcmuir Robert Muir added a comment - Thanks again Tom!
              Hide
              Permalink
              rcmuir Robert Muir added a comment -

              While adding more assertions to the tests, i noticed i somehow screwed up the backport here... this bugfix and test were never backported to 4.1.

              Show
              rcmuir Robert Muir added a comment - While adding more assertions to the tests, i noticed i somehow screwed up the backport here... this bugfix and test were never backported to 4.1.
              Hide
              Permalink
              thetaphi Uwe Schindler added a comment -

              Closed after release.

              Show
              thetaphi Uwe Schindler added a comment - Closed after release.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  tomsh TomShally
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development