Lucene - Core
  1. Lucene - Core
  2. LUCENE-4496

Don't decode unnecessary freq blocks in 4.1 codec

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1
    • Fix Version/s: 4.1, Trunk
    • Component/s: core/codecs
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.

      1. LUCENE-4496.patch
        16 kB
        Robert Muir
      2. LUCENE-4496.patch
        6 kB
        Robert Muir
      3. LUCENE-4496.patch
        2 kB
        Robert Muir

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1d 1h 1m 1 Robert Muir 23/Oct/12 05:47
        Resolved Resolved Closed Closed
        93d 1h 46m 1 Steve Rowe 24/Jan/13 06:33
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1401160

        LUCENE-4496: don't decode unnecessary blocks in 4.1 codec

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1401160 LUCENE-4496 : don't decode unnecessary blocks in 4.1 codec
        Steve Rowe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Robert Muir made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 4.1 [ 12321140 ]
        Fix Version/s 5.0 [ 12321663 ]
        Resolution Fixed [ 1 ]
        Hide
        Robert Muir added a comment -

        I committed to trunk... will give it some time in jenkins before backporting.

        Show
        Robert Muir added a comment - I committed to trunk... will give it some time in jenkins before backporting.
        Robert Muir made changes -
        Attachment LUCENE-4496.patch [ 12550294 ]
        Hide
        Robert Muir added a comment -

        Same patch, adding a few comments and beefing up TestBlockPostingsFormat3 to also check the freqs case.

        I'll commit this shortly after running some more tests, and I think I want to now yank TestBlockPostingsFormat3 out of this package and let it run with any codec, it just tests these various "subset" cases and isnt specific to this PF.

        Show
        Robert Muir added a comment - Same patch, adding a few comments and beefing up TestBlockPostingsFormat3 to also check the freqs case. I'll commit this shortly after running some more tests, and I think I want to now yank TestBlockPostingsFormat3 out of this package and let it run with any codec, it just tests these various "subset" cases and isnt specific to this PF.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Robert Muir made changes -
        Attachment LUCENE-4496.patch [ 12550241 ]
        Hide
        Robert Muir added a comment -

        same trick for .pay blocks when they arent needed.

        Show
        Robert Muir added a comment - same trick for .pay blocks when they arent needed.
        Robert Muir made changes -
        Field Original Value New Value
        Attachment LUCENE-4496.patch [ 12550238 ]
        Hide
        Robert Muir added a comment -

        All tests pass, not sure I trust they really test this case well or even how much it helps, but its a simple fix.

        Show
        Robert Muir added a comment - All tests pass, not sure I trust they really test this case well or even how much it helps, but its a simple fix.
        Robert Muir created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development