Lucene - Core
  1. Lucene - Core
  2. LUCENE-4446

Switch to BlockPostingsFormat for Lucene 4.1

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1, 5.0
    • Component/s: core/codecs
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This has baked for some time: no crazy fails in hudson or anything.

      The code (in my opinion) is actually a lot simpler than the current postings format, its faster, the indexes are smaller, and so on.

      We should probably spend some time just going over the code and adding some more tests and such but I think its time to start looking at cutting over.

        Activity

        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Adrien Grand added a comment -

        +1!

        Show
        Adrien Grand added a comment - +1!
        Hide
        Robert Muir added a comment -

        I think we are good here to switch over.

        I reviewed this PostingsFormat and we improved the docs, and got thru some little issues.
        Test coverage is now much better (https://builds.apache.org/job/Lucene-Solr-Clover-trunk/clover/org/apache/lucene/codecs/block/pkg-summary.html).
        Besides, the whole thing has been baking for a long time without any test failures.

        I'll make a branch to cut this one over and see what it looks like.

        Show
        Robert Muir added a comment - I think we are good here to switch over. I reviewed this PostingsFormat and we improved the docs, and got thru some little issues. Test coverage is now much better ( https://builds.apache.org/job/Lucene-Solr-Clover-trunk/clover/org/apache/lucene/codecs/block/pkg-summary.html ). Besides, the whole thing has been baking for a long time without any test failures. I'll make a branch to cut this one over and see what it looks like.
        Hide
        Robert Muir added a comment -

        Branch is ready for merging (/lucene/dev/branches/lucene4446).

        Show
        Robert Muir added a comment - Branch is ready for merging (/lucene/dev/branches/lucene4446).
        Hide
        Michael McCandless added a comment -

        +1

        I diff'd branch vs trunk and it looks good! Looks like this was quite a bit of work Thanks Robert!

        Show
        Michael McCandless added a comment - +1 I diff'd branch vs trunk and it looks good! Looks like this was quite a bit of work Thanks Robert!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1400562

        LUCENE-4446: add changes entry

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1400562 LUCENE-4446 : add changes entry
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1398129

        LUCENE-4446: flip file formats to point to 4.1 format

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1398129 LUCENE-4446 : flip file formats to point to 4.1 format
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1398121

        LUCENE-4446: Switch to BlockPostingsFormat for Lucene 4.1

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1398121 LUCENE-4446 : Switch to BlockPostingsFormat for Lucene 4.1
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1396064

        LUCENE-4446: factor blocktree's documentation out of Lucene40/Block, minor cleanups to Block's docs

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1396064 LUCENE-4446 : factor blocktree's documentation out of Lucene40/Block, minor cleanups to Block's docs

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development