Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4443

BlockPostingsFormat writes unnecessary skipdata

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0
    • 4.1, 6.0
    • core/codecs
    • None
    • New

    Description

      Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly is 0: see BlockPostingsWriter.startDoc.

      (Unless I'm missing something, all tests pass with "Block" if i remove it)

      Separately we should really think about lastPayloadByteUpto, is this worth it? instead when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we are going to decode that block anyway?

      Attachments

        1. LUCENE-4443.patch
          8 kB
          Robert Muir

        Activity

          People

            Unassigned Unassigned
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: