Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4380

fix simplefs/niofshierarchy

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0, 6.0
    • None
    • None
    • New

    Description

      spinoff from LUCENE-4371:

      Currently NIOFSDirectory.NIOFSIndexInput extends SimpleFSDirectory.SimpleFSIndexInput, but this isn't an is-a relationship at all.

      Additionally SimpleFSDirectory has a funky Descriptor class that extends RandomAccessFile that is useless:

          /**
           * Extension of RandomAccessFile that tracks if the file is 
           * open.
           */
      ...
            // remember if the file is open, so that we don't try to close it
            // more than once
      

      RandomAccessFile is closeable, this is not necessary and I don't think we should be subclassing it.

      Attachments

        1. LUCENE-4380.patch
          10 kB
          Robert Muir
        2. LUCENE-4380.patch
          9 kB
          Robert Muir

        Activity

          People

            Unassigned Unassigned
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: