[LUCENE-4377] consolidate various copyBytes() methods

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0, 6.0
• Lucene Fields: New
• Assignee: Robert Muir
• Reporter: Robert Muir
• Created: 11/Sep/12 23:55
• Updated: 28/Aug/22 13:26
• Resolved: 12/Sep/12 12:30

Description

Spinoff of LUCENE-4371:

I don't think the default impl (SlicedIndexInput) should overrided BII's copyBytes? Seems ... spooky.

There are copyBytes everywhere, mostly not really being used.
Particularly DataOutput.copyBytes(DataInput) versus IndexInput.copyBytes(IndexOutput).

Bulk merging already uses DataOutput.copyBytes(DataInput), its the most general (as it works on DataInput/Output), and its in dst, src order.

I think we should remove IndexInput.copyBytes, its not necessary.