Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spinoff of LUCENE-4371:

      I don't think the default impl (SlicedIndexInput) should overrided BII's copyBytes? Seems ... spooky.

      There are copyBytes everywhere, mostly not really being used.
      Particularly DataOutput.copyBytes(DataInput) versus IndexInput.copyBytes(IndexOutput).

      Bulk merging already uses DataOutput.copyBytes(DataInput), its the most general (as it works on DataInput/Output), and its in dst, src order.

      I think we should remove IndexInput.copyBytes, its not necessary.

        Activity

        Hide
        rcmuir Robert Muir added a comment -

        I want to fix this for 4.0 so we don't have to maintain deprecated implementations.

        Show
        rcmuir Robert Muir added a comment - I want to fix this for 4.0 so we don't have to maintain deprecated implementations.
        Hide
        mikemccand Michael McCandless added a comment -

        +1

        Show
        mikemccand Michael McCandless added a comment - +1
        Hide
        thetaphi Uwe Schindler added a comment -

        +1, this annoyed me since long time!

        Show
        thetaphi Uwe Schindler added a comment - +1, this annoyed me since long time!
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [branch_4x commit] Robert Muir
        http://svn.apache.org/viewvc?view=revision&revision=1383911

        LUCENE-4377: Remove IndexInput.copyBytes(IndexOutput, long)

        Show
        commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1383911 LUCENE-4377 : Remove IndexInput.copyBytes(IndexOutput, long)
        Hide
        thetaphi Uwe Schindler added a comment -

        Closed after release.

        Show
        thetaphi Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            rcmuir Robert Muir
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development