Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4377

consolidate various copyBytes() methods

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spinoff of LUCENE-4371:

      I don't think the default impl (SlicedIndexInput) should overrided BII's copyBytes? Seems ... spooky.

      There are copyBytes everywhere, mostly not really being used.
      Particularly DataOutput.copyBytes(DataInput) versus IndexInput.copyBytes(IndexOutput).

      Bulk merging already uses DataOutput.copyBytes(DataInput), its the most general (as it works on DataInput/Output), and its in dst, src order.

      I think we should remove IndexInput.copyBytes, its not necessary.

        Attachments

          Activity

            People

            • Assignee:
              rcmuir Robert Muir
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: