Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4362

ban tab-indented source

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0, 6.0
    • None
    • None
    • New

    Description

      This makes code really difficult to read and work with.
      Its easy enough to prevent.

      Index: build.xml
      ===================================================================
      --- build.xml	(revision 1380979)
      +++ build.xml	(working copy)
      @@ -77,11 +77,12 @@
               <or>
                 <containsregexp expression="@author\b" casesensitive="yes"/>
                 <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
      +          <containsregexp expression="\t" casesensitive="no"/>
               </or>
             </fileset>
             <map from="${validate.currDir}${file.separator}" to="* "/>
           </pathconvert>
      -    <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
      +    <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
         </target>
      

      Attachments

        1. LUCENE-4362.patch
          65 kB
          Robert Muir
        2. LUCENE-4362.patch
          907 kB
          Erick Erickson
        3. LUCENE-4362_trunk.patch
          935 kB
          Erick Erickson
        4. LUCENE-4362_trunk.patch
          935 kB
          Erick Erickson
        5. LUCENE-4362_trunk.patch
          934 kB
          Erick Erickson
        6. LUCENE-4362_core.patch
          23 kB
          Robert Muir
        7. LUCENE-4362_4x.patch
          930 kB
          Erick Erickson
        8. LUCENE-4362_4x.patch
          994 kB
          Erick Erickson
        9. LUCENE-4362_4x.patch
          1011 kB
          Erick Erickson
        10. LUCENE-4362_4x.patch
          1011 kB
          Erick Erickson
        11. LUCENE-4362_4x.patch
          1011 kB
          Erick Erickson

        Activity

          People

            erickerickson Erick Erickson
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: