Lucene - Core
  1. Lucene - Core
  2. LUCENE-4335

Builds should regenerate all generated sources

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We have more and more sources that are generated programmatically (query parsers, fuzzy levN tables from Moman, packed ints specialized decoders, etc.), and it's dangerous because developers may directly edit the generated sources and forget to edit the meta-source. It's happened to me several times ... most recently just after landing the BlockPostingsFormat branch.

      I think we should re-gen all of these in our builds and fail the build if this creates a difference. I know some generators (eg JavaCC) embed timestamps and so always create mods ... we can leave them out of this for starters (or maybe post-process the sources to remove the timestamps) ...

      1. LUCENE-4335.patch
        39 kB
        Robert Muir
      2. LUCENE-4335.patch
        22 kB
        Michael McCandless
      3. LUCENE-4335.patch
        2 kB
        Michael McCandless

        Issue Links

          Activity

          Michael McCandless created issue -
          Michael McCandless made changes -
          Field Original Value New Value
          Attachment LUCENE-4335.patch [ 12542911 ]
          Michael McCandless made changes -
          Assignee Michael McCandless [ mikemccand ]
          Michael McCandless made changes -
          Attachment LUCENE-4335.patch [ 12593766 ]
          Robert Muir made changes -
          Attachment LUCENE-4335.patch [ 12593930 ]
          Steve Rowe made changes -
          Link This issue is blocked by LUCENE-5552 [ LUCENE-5552 ]

            People

            • Assignee:
              Michael McCandless
              Reporter:
              Michael McCandless
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development