Lucene - Core
  1. Lucene - Core
  2. LUCENE-4316

Deprecate Fields.getUniqueTermCount, remove AtomicReader.getUniqueTermCount

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Spinoff from LUCENE-4315.

      This was my comment there:

      we should consider Fields.getUniqueTermCount,
      which has a default implementation that sums across fields (preflex overrides).
      
      This was necessary to have some way to access the segment-level unique term count for 3.x indexes,
      which do not actually know this information per-field and override this method to provide it.
      
      But there is no need to have this on AtomicReader (I think its way too expert, just get the Fields
      and get it from there), and we can consider deprecating this in 4.x and removing it in trunk
      alltogether as then someone can just use the field-level statistics.
      

        Activity

        Hide
        Robert Muir added a comment -

        patch for branch_4x. I would remove the deprecation in trunk and fix those tests.

        Show
        Robert Muir added a comment - patch for branch_4x. I would remove the deprecation in trunk and fix those tests.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Uwe Schindler added a comment -

        +1

        Show
        Uwe Schindler added a comment - +1
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development