Lucene - Core
  1. Lucene - Core
  2. LUCENE-4235

Remove enforcing of Filter Rewrite for NRQ queries

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-BETA, 6.0
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Back in Lucene 2.9, I hardcoded NRQ to always use filter rewrite based on the precisionStep. This is bogus and contradicts our autodetection (which may need some overhaul now in Lucene 4.0).

      If a query rewrites to only one term, using filter rewrite is stupid and slows down a lot, it can do a simple CSQ(TermQuery()) which is incredibly fast.

      This issue will remove the line from the CTOR.

      1. LUCENE-4235.patch
        4 kB
        Uwe Schindler
      2. LUCENE-4235.patch
        2 kB
        Uwe Schindler

        Activity

        Hide
        Uwe Schindler added a comment -

        Easy patch, simplification. Will commit soon!

        Show
        Uwe Schindler added a comment - Easy patch, simplification. Will commit soon!
        Hide
        Uwe Schindler added a comment -

        I missed to disable the check in the test. Now it's ready.

        Show
        Uwe Schindler added a comment - I missed to disable the check in the test. Now it's ready.
        Hide
        Uwe Schindler added a comment -

        Committed trunk revision: 1363049
        Committed 4.x revision: 1363051

        Show
        Uwe Schindler added a comment - Committed trunk revision: 1363049 Committed 4.x revision: 1363051

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development