[LUCENE-4166] TwoDoublesStrategy is broken for Circles

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 4.0-ALPHA, 6.0
• Component/s: modules/spatial
• Lucene Fields: New
• Assignee: Chris Male
• Reporter: Chris Male
• Created: 27/Jun/12 11:20
• Updated: 09/May/16 18:31
• Resolved: 28/Jun/12 03:01

Description

TwoDoublesStrategy supports finding Documents that are within a Circle, yet it is impossible to provide one due to the following code found at the start of TwoDoublesStrategy.makeQuery():

Shape shape = args.getShape();
    if (!(shape instanceof Rectangle)) {
      throw new InvalidShapeException("A rectangle is the only supported shape (so far), not "+shape.getClass());//TODO
    }
    Rectangle bbox = (Rectangle) shape;

I think instead the code which handles Circles should ask for the bounding box of the Shape and uses that instead.