Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4164

Improve IndexWriter.addIndexes(IndexReader) javadocs

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 4.0-ALPHA, 6.0
    • core/index
    • None
    • New, Patch Available

    Description

      IndexWriter.addIndexes(IndexReader) needs some improvements:

      • It falsely states that this method blocks any add/delete documents attempts.
      • It merges all input IndexReaders at once, and not e.g. like MergePolicy does at mergeFactor steps. Therefore I think it'd be good to clarify it to the user, and also encourage him to call this method several times if he has many IndexReaders to merge.
        • And while at it, mentioning that the IR can be opened with termIndexInterval=-1 since we don't need it during merge will be good – saves RAM.

      I'll attach a patch shortly.

      Attachments

        1. LUCENE-4164.patch
          3 kB
          Shai Erera

        Activity

          People

            shaie Shai Erera
            shaie Shai Erera
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: