Lucene - Core
  1. Lucene - Core
  2. LUCENE-4155

Move & hide ReaderSlice and BitSlice classes (and possibly others) to oal.index package; move ReaderUtil to oal.index

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA, 6.0
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Those are used solely by the index package and are very internal (just helper classes), so they should be hidden from the user. This can be done by adding the pkg-private to index package.

      ReaderUtil was cleaned up in LUCENE-3866, should stay public, but is in wrong package since Lucene 2.9. We should move it to oal.index package, too. Its name suggests that.

      1. LUCENE-4155.patch
        153 kB
        Uwe Schindler
      2. LUCENE-4155.patch
        48 kB
        Uwe Schindler
      3. LUCENE-4155.patch
        40 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          Path that moves those 3 classes to index package. Unfortunately, I was only able to make BitsSlice pkg-private (only used by MultiDocsEnum,...), ReaderSlice must be public, as used by Codecs.

          Show
          Uwe Schindler added a comment - Path that moves those 3 classes to index package. Unfortunately, I was only able to make BitsSlice pkg-private (only used by MultiDocsEnum,...), ReaderSlice must be public, as used by Codecs.
          Hide
          Uwe Schindler added a comment -

          I marked those classes as @lucene.internal, this was missing before.

          Show
          Uwe Schindler added a comment - I marked those classes as @lucene.internal, this was missing before.
          Hide
          Uwe Schindler added a comment -

          New patch. This one also moves the very custom "MultiBits" class and makes it private. This one should never be public, especially as it exports some very "IndexReader" special features. It is no longer of general use.

          Show
          Uwe Schindler added a comment - New patch. This one also moves the very custom "MultiBits" class and makes it private. This one should never be public, especially as it exports some very "IndexReader" special features. It is no longer of general use.
          Hide
          Uwe Schindler added a comment -

          Doning more review: Why is CodecUtil in util package? Just because it ends in *Util? In my opinion, it should be in codec package.

          Show
          Uwe Schindler added a comment - Doning more review: Why is CodecUtil in util package? Just because it ends in *Util? In my opinion, it should be in codec package.
          Hide
          Uwe Schindler added a comment -

          More: DummyConcurrentLock is dead and should be removed. It was only there to implement MultiSearcher and ParallelMultiSearcher using same code.

          Show
          Uwe Schindler added a comment - More: DummyConcurrentLock is dead and should be removed. It was only there to implement MultiSearcher and ParallelMultiSearcher using same code.
          Hide
          Uwe Schindler added a comment -

          TwoPhaseCommit(Tool) should also be in index package.

          Show
          Uwe Schindler added a comment - TwoPhaseCommit(Tool) should also be in index package.
          Hide
          Uwe Schindler added a comment -

          New patch with moving renaming more classes to appropinquate packages:

          • CodecUtils to codecs package
          • TwoPhaseCommit* and TermContext to index package

          I will commit this later today, as patch might get outdated soon.

          Show
          Uwe Schindler added a comment - New patch with moving renaming more classes to appropinquate packages: CodecUtils to codecs package TwoPhaseCommit* and TermContext to index package I will commit this later today, as patch might get outdated soon.
          Hide
          Michael McCandless added a comment -

          +1, thanks Uwe!

          Show
          Michael McCandless added a comment - +1, thanks Uwe!
          Hide
          Uwe Schindler added a comment -

          Committed trunk revision: 1352942, 1352949
          Backported 4.x revision: 1352956

          I hope all compiles and tests on Jenkins!

          Show
          Uwe Schindler added a comment - Committed trunk revision: 1352942, 1352949 Backported 4.x revision: 1352956 I hope all compiles and tests on Jenkins!

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development