Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4153

Fast vector highlighting should be aware of field boundaries in case of mv fields.

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.0-BETA
        • Component/s: None
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          Improve fast vector highlighter to respect field boundaries in the case for multivalued fields.

          1. Text File
            LUCENE-4153.patch
            16 kB
            Martijn van Groningen
          2. Text File
            LUCENE-4153.patch
            11 kB
            Martijn van Groningen

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            martijn.v.groningen Martijn van Groningen added a comment -

            Initial approach to make fvh respect field boundaries when highlighting on mv fields.

            Basically in the BaseFragmentsBuilder the fragInfos are checked if not crossing field boundaries. If so a fragInfo might be modified or split. This approach seems good to me. Maybe others have a different opinion?

            This behavior can be enabled with the discreteMultiValueHighlighting boolean property.

            Show
            martijn.v.groningen Martijn van Groningen added a comment - Initial approach to make fvh respect field boundaries when highlighting on mv fields. Basically in the BaseFragmentsBuilder the fragInfos are checked if not crossing field boundaries. If so a fragInfo might be modified or split. This approach seems good to me. Maybe others have a different opinion? This behavior can be enabled with the discreteMultiValueHighlighting boolean property.
            Hide
            Permalink
            martijn.v.groningen Martijn van Groningen added a comment -

            Added more test coverage. I'll commit soon.

            Show
            martijn.v.groningen Martijn van Groningen added a comment - Added more test coverage. I'll commit soon.
            Hide
            Permalink
            martijn.v.groningen Martijn van Groningen added a comment -

            Committed to trunk and branch4x.

            Show
            martijn.v.groningen Martijn van Groningen added a comment - Committed to trunk and branch4x.

              People

              • Assignee:
                Unassigned
                Reporter:
                martijn.v.groningen Martijn van Groningen
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development