Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4122

Replace Payload with BytesRef

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.0-ALPHA, 6.0
        • Fix Version/s: 4.0-ALPHA, 6.0
        • Component/s: core/index
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          The Payload class offers a very similar functionality to BytesRef. The code internally uses BytesRef-s to represent payloads, and on indexing and on retrieval this data is repackaged from/to Payload.

          This seems wasteful. I propose to remove the Payload class and use BytesRef instead, thus avoid this re-wrapping and reducing the API footprint.

          1. Text File
            LUCENE-4122.patch
            69 kB
            Andrzej Bialecki

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ab Andrzej Bialecki added a comment -

            Patch for trunk. All tests pass.

            Show
            ab Andrzej Bialecki added a comment - Patch for trunk. All tests pass.
            Hide
            Permalink
            rcmuir Robert Muir added a comment -

            +1

            Show
            rcmuir Robert Muir added a comment - +1
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            +1

            Show
            mikemccand Michael McCandless added a comment - +1
            Hide
            Permalink
            ab Andrzej Bialecki added a comment -

            Committed in rev. 1348171 to trunk and in rev. 1348227 to branch_4x.

            Show
            ab Andrzej Bialecki added a comment - Committed in rev. 1348171 to trunk and in rev. 1348227 to branch_4x.

              People

              • Assignee:
                ab Andrzej Bialecki
                Reporter:
                ab Andrzej Bialecki
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development