Lucene - Core
  1. Lucene - Core
  2. LUCENE-4079

The hunspell filter should support compressed Hunspell dictionaries

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.5, 3.6, 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA, 3.6.1, 5.0
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      OpenOffice dictionaries are often compressed via some aliases on the beginning of the affixe file. The french one for instance.
      Currently the hunspell filter does not read the aliases.

      1. LUCENE-4079-3.6.x.patch
        7 kB
        ludovic Boutros
      2. LUCENE-4079-trunk.patch
        6 kB
        ludovic Boutros

        Issue Links

          Activity

          Hide
          ludovic Boutros added a comment -

          I manage to load french compressed dictionaries with this little patch.

          Show
          ludovic Boutros added a comment - I manage to load french compressed dictionaries with this little patch.
          Hide
          ludovic Boutros added a comment -

          little changes.

          Show
          ludovic Boutros added a comment - little changes.
          Hide
          Simon Willnauer added a comment -

          Ludovic, I moved this to lucene since its a lucene issue.

          Show
          Simon Willnauer added a comment - Ludovic, I moved this to lucene since its a lucene issue.
          Hide
          Chris Male added a comment -

          Thanks Simon

          Show
          Chris Male added a comment - Thanks Simon
          Hide
          ludovic Boutros added a comment -

          oups, yes you are right, thank you Simon.

          Show
          ludovic Boutros added a comment - oups, yes you are right, thank you Simon.
          Hide
          ludovic Boutros added a comment -

          patch renamed.

          Show
          ludovic Boutros added a comment - patch renamed.
          Hide
          Chris Male added a comment -

          Ludovic, do you think you could include some tests to verify this behavior?

          Show
          Chris Male added a comment - Ludovic, do you think you could include some tests to verify this behavior?
          Hide
          ludovic Boutros added a comment -

          The patch with a test unit.

          I don't know if a compressed dictionary could use both naming types (alias and direct rule name).
          In the c++ code it seems that it is not possible so I did not test it in the java code.

          Show
          ludovic Boutros added a comment - The patch with a test unit. I don't know if a compressed dictionary could use both naming types (alias and direct rule name). In the c++ code it seems that it is not possible so I did not test it in the java code.
          Hide
          Chris Male added a comment -

          Ludovic,

          Sorry to keep asking for changes, but do you think you could make your patch against trunk?

          Show
          Chris Male added a comment - Ludovic, Sorry to keep asking for changes, but do you think you could make your patch against trunk?
          Hide
          ludovic Boutros added a comment -

          No problem, I will try to make the patch against trunk today.

          Show
          ludovic Boutros added a comment - No problem, I will try to make the patch against trunk today.
          Hide
          ludovic Boutros added a comment -

          Ok, I have merged some typo corrections from the trunk to the branch 3.6.
          I have applied the patch to the trunk, and run the tests.

          Do you need something else ?

          Show
          ludovic Boutros added a comment - Ok, I have merged some typo corrections from the trunk to the branch 3.6. I have applied the patch to the trunk, and run the tests. Do you need something else ?
          Hide
          Chris Male added a comment -

          Thanks Ludovic, I'll take a look.

          Show
          Chris Male added a comment - Thanks Ludovic, I'll take a look.
          Hide
          Chris Male added a comment -

          Committed to trunk in r1344095, 4x in r1344094.

          Will backport to 3.6.1

          Show
          Chris Male added a comment - Committed to trunk in r1344095, 4x in r1344094. Will backport to 3.6.1
          Hide
          Chris Male added a comment -

          Backported in r1344101.

          Show
          Chris Male added a comment - Backported in r1344101.
          Hide
          Chris Male added a comment -

          Thanks Ludovic!

          Show
          Chris Male added a comment - Thanks Ludovic!
          Hide
          ludovic Boutros added a comment -

          Thanks Chris for taking this patch in account so fast !

          Show
          ludovic Boutros added a comment - Thanks Chris for taking this patch in account so fast !
          Hide
          Uwe Schindler added a comment -

          Bulk close for 3.6.1

          Show
          Uwe Schindler added a comment - Bulk close for 3.6.1

            People

            • Assignee:
              Chris Male
              Reporter:
              ludovic Boutros
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development