Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-4064

Move ContentSource to PerfRunData out of DocMaker

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/benchmark
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      ContentSource is currently private to DocMaker, however if someone wants to write an AddDocTask that does not use DocMaker, he needs to initialize ContentSource by himself.

      It would be better if ContentSource is a shared resource on PerfRunData that is used by DocMaker, rather than owned by it.

      I'll post a patch shortly.

        Activity

        Hide
        shaie Shai Erera added a comment -

        Patch:

        • Moves ContentSource outside of DocMaker to PerfRunData
        • Fixes ConsumeContentSourceTask to behave well in a multi-threaded benchmark

        I think this is ready to commit.

        Show
        shaie Shai Erera added a comment - Patch: Moves ContentSource outside of DocMaker to PerfRunData Fixes ConsumeContentSourceTask to behave well in a multi-threaded benchmark I think this is ready to commit.
        Hide
        shaie Shai Erera added a comment -

        Committed revision 1339555.

        Show
        shaie Shai Erera added a comment - Committed revision 1339555.

          People

          • Assignee:
            shaie Shai Erera
            Reporter:
            shaie Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development