[LUCENE-4061] Improvements to DirectoryTaxonomyWriter (synchronization and others)

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0-ALPHA, 6.0
• Component/s: modules/facet
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Shai Erera
• Created: 16/May/12 08:10
• Updated: 28/Aug/22 13:16
• Resolved: 19/Jun/12 12:35

Description

DirTaxoWriter synchronizes in too many places. For instance addCategory() is fully synchronized, while only a small part of it needs to be.

Additionally, getCacheMemoryUsage looks bogus - it depends on the type of the TaxoWriterCache. No code uses it, so I'd like to remove it – whoever is interested can query the specific cache impl it has. Currently, only Cl2oTaxoWriterCache supports it.

If the changes will be simple, I'll port them to 3.6.1 as well.