[LUCENE-4060] DirectoryTaxonomyWriter.addTaxonomies does not work well in a multi-threaded environment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Fix Version/s: 4.0-ALPHA, 3.6.1
• Component/s: modules/facet
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Shai Erera
• Created: 16/May/12 06:45
• Updated: 22/Jul/12 16:04
• Resolved: 16/May/12 08:03

Description

DirTaxoWriter.addTaxonomies may lead to a corrupt taxonomy index if addCategory is called in parallel. While reviewing the code, the following changes seemed to be required:

• Fix the bug
• Simplify addTaxonomies code – it's very complicated, seems rather inefficient, and seems to take care of more than is needed.
• The intention to support multiple taxonomies is unclear, especially since FacetsPayloadProcessor can handle only one Directory and one OrdinalMap at a time. So I'd like to change the method to addTaxonomy. I anyway don't see the reason to add multiple taxonomies at once, one can call addTaxonomy several times.

I will post a patch soon.