Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: general/build, general/test
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The only exceptions are setUp/ tearDown methods in LuceneTestCase, which are historically designed for overriding (and for which chaining is verified). Any other override of am instance hook method should just be banned as it is very likely a mistake.

        Issue Links

          Activity

          Hide
          Dawid Weiss added a comment -

          The tests for this should not fire when run in stand-alone mode because this confuses intellij idea. I think a safe bet would be to check if we're a nested class – if so, don't run any validations.

          Show
          Dawid Weiss added a comment - The tests for this should not fire when run in stand-alone mode because this confuses intellij idea. I think a safe bet would be to check if we're a nested class – if so, don't run any validations.
          Hide
          Dawid Weiss added a comment -

          Committed a fix for this.

          Show
          Dawid Weiss added a comment - Committed a fix for this.
          Hide
          Steve Rowe added a comment -

          Thanks Dawid - IntelliJ now shows an icon indicating the affected test is ignored, and no exception is printed.

          Show
          Steve Rowe added a comment - Thanks Dawid - IntelliJ now shows an icon indicating the affected test is ignored, and no exception is printed.
          Hide
          Dawid Weiss added a comment -

          Yup, this time I checked Thanks for testing.

          Show
          Dawid Weiss added a comment - Yup, this time I checked Thanks for testing.
          Hide
          Dawid Weiss added a comment -

          Fixed a while ago.

          Show
          Dawid Weiss added a comment - Fixed a while ago.

            People

            • Assignee:
              Dawid Weiss
              Reporter:
              Dawid Weiss
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development