Lucene - Core
  1. Lucene - Core
  2. LUCENE-4048

Move getLines out of ResourceLoader and require Charset

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      ResourceLoader.getLines() is only used by analysis factories. SolrResourceLoader's implementation does the job well and it's unlikely that another ResourceLoader implementation would handle it differently.

      We should extract the getLines() method out to AbstractAnalysisFactory so it can be used by the factories. Additionally we shouldn't assume the files are encoded in UTF-8, instead we should allow a Charset to be specified.

      This would take us one step closer to reducing the ResourceLoader interface just to what it says, a loader of resources.

      1. LUCENE-4048.patch
        27 kB
        Chris Male
      2. LUCENE-4048.patch
        16 kB
        Chris Male

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development