Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    1. LUCENE-4031.patch
      13 kB
      Robert Muir
    2. LUCENE-4031.patch
      15 kB
      Robert Muir

      Activity

      Hide
      Robert Muir added a comment -

      updated patch fixing a bug... got lost tracing my way through NestedPulsing, not understanding why it was only tripped there. Problem was alwaysCodec(Pulsing()) is dangerous for testing enums like this, as each doc will only have tf=1

      Show
      Robert Muir added a comment - updated patch fixing a bug... got lost tracing my way through NestedPulsing, not understanding why it was only tripped there. Problem was alwaysCodec(Pulsing()) is dangerous for testing enums like this, as each doc will only have tf=1
      Hide
      Robert Muir added a comment -

      Ill work on this coverage separately.

      Also i think Sep is the only postingswriter left that doesnt support offsets.
      If we could fix that we could really generalize the tests better (e.g. its then just !PreFlex)..

      Show
      Robert Muir added a comment - Ill work on this coverage separately. Also i think Sep is the only postingswriter left that doesnt support offsets. If we could fix that we could really generalize the tests better (e.g. its then just !PreFlex)..
      Hide
      Michael McCandless added a comment -

      +1 patch looks great!

      I agree we need better test coverage...

      Show
      Michael McCandless added a comment - +1 patch looks great! I agree we need better test coverage...
      Hide
      Robert Muir added a comment -

      First cut at a patch, tests are passing.

      I think (sorta unrelated, just noticed while looking around), we need to beef up tests for all codecs, not just the ones that support this:

      • docs/d&penum reuse across all different possibilities (payloads on/off, indexoptions)
      • asking for stuff thats not there (e.g. freqs when its omitTF, asking for offsets when they arent indexed) and ensuring thats null in all codecs.
      Show
      Robert Muir added a comment - First cut at a patch, tests are passing. I think (sorta unrelated, just noticed while looking around), we need to beef up tests for all codecs, not just the ones that support this: docs/d&penum reuse across all different possibilities (payloads on/off, indexoptions) asking for stuff thats not there (e.g. freqs when its omitTF, asking for offsets when they arent indexed) and ensuring thats null in all codecs.

        People

        • Assignee:
          Unassigned
          Reporter:
          Robert Muir
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development