Lucene - Core
  1. Lucene - Core
  2. LUCENE-4023

Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
    • Fix Version/s: 3.6.1
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.

      I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():

      If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.

      This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.

      1. LUCENE-4023.patch
        3 kB
        Uwe Schindler

        Activity

        Hide
        Uwe Schindler added a comment -

        Bulk close for 3.6.1

        Show
        Uwe Schindler added a comment - Bulk close for 3.6.1
        Hide
        Uwe Schindler added a comment -

        Committed to realease branch revision: 1331296

        Show
        Uwe Schindler added a comment - Committed to realease branch revision: 1331296
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Uwe Schindler added a comment -

        Patch. The change in DisjMaxScorer should be forward-ported to new trunk API.

        Show
        Uwe Schindler added a comment - Patch. The change in DisjMaxScorer should be forward-ported to new trunk API.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development