[LUCENE-4023] Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package; DisjunctionMaxScorer does not implement it

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1, 3.2, 3.3, 3.4, 3.5, 3.6
• Fix Version/s: 3.6.1
• Component/s: core/search
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 26/Apr/12 11:35
• Updated: 22/Jul/12 16:04
• Resolved: 27/Apr/12 08:40

Description

Scorer.visitSubScorers() is protected which make it impossible to implement it on a composite scorer in another package.

I came around this issue when I tried to write a workaround for the 2nd problem of this issue: DisjunctionMaxScorer does not implement visitSubScorers():

If you write a Scorer in another package than o.a.l.search and implement visit subScorers(), you may need to call the visitSubScorers method recursively on your leaves (sub-scorers). But this is not possible, as the method is protected.

This issue should also fix the missing implementation of visitSubScorers in DisjMaxQuery.