I searched *build.xml for "modules/" and "contrib". "modules/" seems to be gone, but there are several names that still have "contrib" in them (e.g. test-contrib) in lucene/build.xml and lucene/common-build.xml. These names can be fixed later.
Yeah I can rename these (at least temporarily) to something more appropriate after committing.
separately another TODO: its slightly confusing that core and friends aren't just another module,
and its confusing common-build.xml with its "module tasks" is included by lucene/build.xml, when
its no module at all.
(try ant -projecthelp from lucene/ and experiment with some of the common.XXXX tasks that show up here).
But, this is the way trunk is today The tradeoff of this approach is that we keep all the same logic
and its really not a drastic change...
I resisted doing these kind of cleanups because they have a chance of breaking something and i think should
be cleaned up separately... but we should still look at it afterwards.