Lucene - Core
  1. Lucene - Core
  2. LUCENE-3952

validate depends on compile-tools, which does too much

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.6, 4.0-ALPHA
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      lucene's common-build.xml 'validate' depends on compile-tools, but some
      modules like icu, kuromoji, etc have a compile-tools target (for other reasons).

      I think it should explicitly depend on common.compile-tools instead.

      1. LUCENE-3952.patch
        0.5 kB
        Robert Muir

        Activity

        Hide
        Hoss Man added a comment -

        with commit r1309556 you can no longer "ant clean compile" from the top level of checkout...

        hossman@bester:~/lucene/dev$ ant clean compile
        ...
        validate:
             [echo] Building spatial...
        
        validate:
             [echo] Building suggest...
        
        validate:
          [taskdef] Could not load definitions from resource lucene-solr.antlib.xml. It could not be found.
             [echo] License check under: /home/hossman/lucene/dev/modules
        
        BUILD FAILED
        /home/hossman/lucene/dev/build.xml:68: The following error occurred while executing this line:
        /home/hossman/lucene/dev/modules/build.xml:68: The following error occurred while executing this line:
        /home/hossman/lucene/dev/lucene/tools/custom-tasks.xml:22: Problem: failed to create task or type licenses
        Cause: The name is undefined.
        Action: Check the spelling.
        Action: Check that any custom tasks/types have been declared.
        Action: Check that any <presetdef>/<macrodef> declarations have taken place.
        
        
        Total time: 14 seconds
        
        Show
        Hoss Man added a comment - with commit r1309556 you can no longer "ant clean compile" from the top level of checkout... hossman@bester:~/lucene/dev$ ant clean compile ... validate: [echo] Building spatial... validate: [echo] Building suggest... validate: [taskdef] Could not load definitions from resource lucene-solr.antlib.xml. It could not be found. [echo] License check under: /home/hossman/lucene/dev/modules BUILD FAILED /home/hossman/lucene/dev/build.xml:68: The following error occurred while executing this line: /home/hossman/lucene/dev/modules/build.xml:68: The following error occurred while executing this line: /home/hossman/lucene/dev/lucene/tools/custom-tasks.xml:22: Problem: failed to create task or type licenses Cause: The name is undefined. Action: Check the spelling. Action: Check that any custom tasks/types have been declared. Action: Check that any <presetdef>/<macrodef> declarations have taken place. Total time: 14 seconds
        Hide
        Robert Muir added a comment -

        trivial patch: this placeholder task shouldnt depend on anything, it does nothing.

        the top-level tasks are the ones actually invoking license-check-macro.

        Show
        Robert Muir added a comment - trivial patch: this placeholder task shouldnt depend on anything, it does nothing. the top-level tasks are the ones actually invoking license-check-macro.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development