Lucene - Core
  1. Lucene - Core
  2. LUCENE-3948

Experiment with placing poms outside of src

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Recent work in LUCENE-3944 has changed how our generated pom.xml files are handled during release preparation, placing them in build/ instead. However get-maven-poms still places the poms inside src/ so you can use them to drive a build. What I think would be ideal is if we could unify the release handling of the poms and the normal building handling, so that the poms can sit outside of src and serve both purposes.

      Some time ago I investigated how the ANT project handles its own Maven integration and it has its poms sitting in their own directory. They then reference the actual src locations inside the poms. This works for ANT but with a warning since some of their tests don't work due to how the Maven surefire plugin works, so they skip their tests.

      I have done some quick testing of my own and this process does seem to work for our poms and tests. I now want to take this to a full scale POC and see if it works fully.

      1. LUCENE-3948.patch
        66 kB
        Steve Rowe
      2. LUCENE-3948.patch
        59 kB
        Steve Rowe
      3. LUCENE-3948.patch
        61 kB
        Chris Male
      4. LUCENE-3948.patch
        56 kB
        Steve Rowe
      5. LUCENE-3948.patch
        56 kB
        Chris Male

        Activity

        Chris Male created issue -
        Chris Male made changes -
        Field Original Value New Value
        Attachment LUCENE-3948.patch [ 12521300 ]
        Steve Rowe made changes -
        Comment [ Hi Chris,

        I applied the patch, ran {{ant filter-pom-templates}} under lucene, {{chdir}}'d to {{lucene/build/poms/}}, and tried the following:

        * {{ ]
        Steve Rowe made changes -
        Attachment LUCENE-3948.patch [ 12521399 ]
        Chris Male made changes -
        Attachment LUCENE-3948.patch [ 12521453 ]
        Steve Rowe made changes -
        Attachment LUCENE-3948.patch [ 12522295 ]
        Steve Rowe made changes -
        Attachment LUCENE-3948.patch [ 12525772 ]
        Steve Rowe made changes -
        Assignee Steven Rowe [ steve_rowe ]
        Steve Rowe made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Lucene Fields New [ 10121 ] New,Patch Available [ 10121,10120 ]
        Fix Version/s 4.0 [ 12314025 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development