Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-3878

CheckIndex should check deleted documents too

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0-ALPHA
    • 4.0-ALPHA
    • None
    • None
    • New

    Description

      In 4.0 livedocs are passed down to the enums, thus deleted docs are not so special.

      So I think checkindex should not pass the livedocs down to the enums when checking,
      it should pass livedocs=null and check all the postings. It already does this separately to
      collect stats i think to compare against the term/collection statistics? But we should
      just clean this up and only use one enum.

      For example LUCENE-3876 is a case where we were actually making a corrumpt index,
      (a position was negative) but because the document in question was deleted, CheckIndex
      didn't detect this.

      This could have caused problems if someone just passed null for livedocs (maybe they
      are doing something where its not so important to take deletions into account)

      Attachments

        1. LUCENE-3878.patch
          32 kB
          Robert Muir
        2. LUCENE-3878.patch
          34 kB
          Robert Muir
        3. LUCENE-3878.patch
          19 kB
          Michael McCandless

        Activity

          People

            Unassigned Unassigned
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: